[MIRROR] Fix lifeline not respecting suit sensors #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix lifeline not respecting suit sensors (#81517) ## About The Pull Request - Lifeline app now respect suits sensors again. - The proc always `return .`'d if the target mob was not on suit sensors, so if `.` was `RADAR_TRACKABLE`, well, it would rack sensorless mobs. - Cleaned up a bit of trackable. - Use the `is_valid_z_level` helper. - Respect all possible returns for a signal. ## Changelog :cl: Melbert fix: Lifeline can no longer track mobs with suit sensors off /:cl: * Fix lifeline not respecting suit sensors --------- Co-authored-by: MrMelbert <[email protected]>
AnywayFarus
added a commit
that referenced
this pull request
Feb 19, 2024
Iajret
pushed a commit
that referenced
this pull request
Apr 18, 2024
* ai controllers use cell trackers to know when to idle (#82691) ## About The Pull Request this makes ai controllers use cell trackers and signals to determine when to idle ## Why It's Good For The Game might be better than looping over all clients for every controller ## Changelog :cl: code: The way mobs idle has been refactored, please report any issues with non-reactive mobs /:cl: * ai controllers use cell trackers to know when to idle --------- Co-authored-by: Ben10Omintrix <[email protected]>
ReezeBL
pushed a commit
that referenced
this pull request
Apr 18, 2024
#2938) * ai controllers use cell trackers to know when to idle (#82691) ## About The Pull Request this makes ai controllers use cell trackers and signals to determine when to idle ## Why It's Good For The Game might be better than looping over all clients for every controller ## Changelog :cl: code: The way mobs idle has been refactored, please report any issues with non-reactive mobs /:cl: * ai controllers use cell trackers to know when to idle --------- Co-authored-by: NovaBot <[email protected]> Co-authored-by: Ben10Omintrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrored on Nova: NovaSector/NovaSector#1014
Original PR: tgstation/tgstation#81517
About The Pull Request
Lifeline app now respect suits sensors again.
return .'d if the target mob was not on suit sensors, so if.wasRADAR_TRACKABLE, well, it would rack sensorless mobs.Cleaned up a bit of trackable.
is_valid_z_levelhelper.Changelog
🆑 Melbert
fix: Lifeline can no longer track mobs with suit sensors off
/:cl: